Move LEGACY_SETTINGS into settings.py #25596
Open
+236
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This data structure makes more sense alongside all the other lists in this file like `COMPILE_TIME_SETTINGS` and `DEPRECATED_SETTINGS`. One of the main reasons for having `LEGACY_SETTINGS` in settings.js was that it was visible for those directly browsing the `.js` file. However, we now have an auto-generated `.rst` file that is the more common way for folks to read about settings. See https://emscripten.org/docs/tools_reference/settings_reference.html I updated this auto-generated document to contain this info.
sbc100
force-pushed
the
LEGACY_SETTINGS
branch
from
b649e8d to
f7b1df8
Compare
|
When I search for code related to settings, I first go to It seems that after this, I also need to go to a third file I wonder if the doc generator could read the data structure from the src/settings.js file? If that's complicated, then I don't feel strongly. LGTM either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This data structure makes more sense alongside all the other lists in this file like
COMPILE_TIME_SETTINGSandDEPRECATED_SETTINGS.One of the main reasons for having
LEGACY_SETTINGSin settings.js was that it was visible for those directly browsing the.jsfile. However, we now have an auto-generated.rstfile that is the more common way for folks to read about settings.See https://emscripten.org/docs/tools_reference/settings_reference.html
I updated this auto-generated document to contain this info.